Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document merge options #349

Merged
merged 6 commits into from
Mar 16, 2022

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Mar 11, 2022

Pull request checklist

Use the following template to make sure your PR fits the Teku documentation standard.

Before creating the PR

Make sure that:

Describe the change

Document recently unhidden merge-related CLI options.

Issue fixed

fixes #348

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • CircleCI workflow
  • Build and QA tools (for example lint or vale)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • Read the Docs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

Preview

see https://pegasys-teku--349.com.readthedocs.build/en/349/Reference/CLI/CLI-Syntax/#ee-endpoint

@alexandratran alexandratran requested a review from a team March 11, 2022 16:21
@alexandratran alexandratran requested review from tbenr and a team March 14, 2022 19:01
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a suggestion. Feel free to improve wordings.

docs/Reference/CLI/CLI-Syntax.md Outdated Show resolved Hide resolved
@alexandratran alexandratran requested a review from a team March 15, 2022 18:48
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback. There are a few gaps that we will need to be address when fully documenting the merge feature.

docs/Reference/CLI/CLI-Syntax.md Outdated Show resolved Hide resolved
docs/Reference/CLI/CLI-Syntax.md Outdated Show resolved Hide resolved
@alexandratran alexandratran merged commit de51662 into Consensys:master Mar 16, 2022
@alexandratran alexandratran deleted the 348-doc-merge-cli branch March 16, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the Merge related CLI options
4 participants