-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document merge options #349
document merge options #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion. Feel free to improve wordings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback. There are a few gaps that we will need to be address when fully documenting the merge feature.
Pull request checklist
Use the following template to make sure your PR fits the Teku documentation standard.
Before creating the PR
Make sure that:
Describe the change
Document recently unhidden merge-related CLI options.
Issue fixed
fixes #348
Impacted parts
For content changes:
For tool changes:
After creating your PR and tests have finished
Make sure that:
and added a preview link.
Preview
see https://pegasys-teku--349.com.readthedocs.build/en/349/Reference/CLI/CLI-Syntax/#ee-endpoint