Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBFT: Ensure that Committed Seal is not zero value #1118

Merged
merged 14 commits into from
Sep 30, 2021
Merged

IBFT: Ensure that Committed Seal is not zero value #1118

Changes from 8 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a2e292f
Ensure there is no zero addr Committed Seal
Jan 28, 2021
f5ce3b0
run gofmt
Jan 28, 2021
5c640cc
Merge branch 'master' into non-zero-committed-seals
vdamle Feb 1, 2021
49c7bd1
Merge branch 'master' into non-zero-committed-seals
vdamle Feb 3, 2021
959c954
Merge branch 'master' into non-zero-committed-seals
vdamle Mar 17, 2021
f5f434b
Merge branch 'master' into non-zero-committed-seals
vdamle Apr 27, 2021
f399e66
Merge branch 'master' into non-zero-committed-seals
vdamle May 28, 2021
c117eb3
Merge branch 'master' into non-zero-committed-seals
Sep 29, 2021
279be71
Remove stale comment
Sep 30, 2021
e1686e4
Add unit test
Sep 30, 2021
a599bdd
Revert "Remove stale comment"
Sep 30, 2021
176fa88
Move comment
Sep 30, 2021
eb9bd0c
Update test with error checking
vdamle Sep 30, 2021
3009ce5
Merge branch 'master' into non-zero-committed-seals
Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion consensus/istanbul/ibft/core/core.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ func (c *core) finalizeMessage(msg *ibfttypes.Message) ([]byte, error) {
msg.Address = c.Address()

// Add proof of consensus
ricardolyn marked this conversation as resolved.
Show resolved Hide resolved
msg.CommittedSeal = []byte{}
// Assign the CommittedSeal if it's a COMMIT message and proposal is not nil
if msg.Code == ibfttypes.MsgCommit && c.current.Proposal() != nil {
msg.CommittedSeal = []byte{}
ricardolyn marked this conversation as resolved.
Show resolved Hide resolved
seal := PrepareCommittedSeal(c.current.Proposal().Hash())
msg.CommittedSeal, err = c.backend.Sign(seal)
if err != nil {
Expand Down