fix: flacky unit test #1248
Merged
fix: flacky unit test #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baptiste-b-pegasys
commented
Sep 3, 2021
baptiste-b-pegasys
commented
- wait group add should be outside the go routine
- it's not possible to have a event that the message has just been handled, so the test may happen too soon.
added 2 commits
September 2, 2021 17:31
wait group outside the go routine retry loop for test that depends on non-triggered state
ricardolyn
approved these changes
Sep 3, 2021
danielporto
pushed a commit
to danielporto/quorum
that referenced
this pull request
Sep 7, 2021
* fix: flacky unit test wait group outside the go routine retry loop for test that depends on non-triggered state * fix: review Co-authored-by: Ricardo Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.