perf: improved func ValidateNodeForTxn node id parsing #1578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced permission ValidateNodeForTxn function contains repeating parsing of enode identifier from NodeInfo.Url field. This fix stores parsed enode id value to cached NodeInfo object and reuse stored value on each ValidateNodeForTxn function call.
In our EOA transactions performance test with enabled enhanced permission, this fix decrease CPU usage on ~10% in collected pprof report.
Benchmark source:
Benchmark fix: