fix Validator Timing Actions delegates

Consensys · Jan 15, 2024 · fc6e725 · fc6e725
1 parent 78fead1
commit fc6e725
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...dator/client/src/main/java/tech/pegasys/teku/validator/client/ValidatorTimingActions.java b/...dator/client/src/main/java/tech/pegasys/teku/validator/client/ValidatorTimingActions.java
@@ -106,9 +106,9 @@ public void onAttestationAggregationDue(final UInt64 slot) {
 
   @Override
   public void onAttesterSlashing(final AttesterSlashing attesterSlashing) {
+    delegates.forEach(delegates -> delegates.onAttesterSlashing(attesterSlashing));
     maybeValidatorSlashedAction.ifPresent(
         validatorSlashingAction -> {
-          delegates.forEach(delegates -> delegates.onAttesterSlashing(attesterSlashing));
           final Set<UInt64> slashedIndices = attesterSlashing.getIntersectingValidatorIndices();
           final List<BLSPublicKey> slashedPublicKeys =
               slashedIndices.stream()
@@ -122,9 +122,9 @@ public void onAttesterSlashing(final AttesterSlashing attesterSlashing) {
 
   @Override
   public void onProposerSlashing(final ProposerSlashing proposerSlashing) {
+    delegates.forEach(delegates -> delegates.onProposerSlashing(proposerSlashing));
     maybeValidatorSlashedAction.ifPresent(
         validatorSlashedAction -> {
-          delegates.forEach(delegates -> delegates.onProposerSlashing(proposerSlashing));
           final UInt64 slashedIndex = proposerSlashing.getHeader1().getMessage().getProposerIndex();
           validatorIndexProvider
               .getPublicKey(slashedIndex.intValue())

diff --git a/...r/client/src/test/java/tech/pegasys/teku/validator/client/ValidatorTimingActionsTest.java b/...r/client/src/test/java/tech/pegasys/teku/validator/client/ValidatorTimingActionsTest.java
@@ -133,7 +133,7 @@ public void shouldNotTriggerValidatorSlashingActionWhenNotEnabled_AttesterSlashi
         dataStructureUtil.randomAttesterSlashing(
             dataStructureUtil.randomValidatorIndex(), dataStructureUtil.randomValidatorIndex());
     validatorTimingActions.onAttesterSlashing(attesterSlashing);
-    verifyNoInteractions(delegate);
+    verify(delegate).onAttesterSlashing(attesterSlashing);
     verifyNoInteractions(validatorIndexProvider);
     verifyNoInteractions(statusLogger);
   }
@@ -147,7 +147,7 @@ public void shouldNotTriggerValidatorSlashingActionWhenNotEnabled_ProposerSlashi
         dataStructureUtil.randomProposerSlashing(
             dataStructureUtil.randomSlot(), dataStructureUtil.randomValidatorIndex());
     validatorTimingActions.onProposerSlashing(proposerSlashing);
-    verifyNoInteractions(delegate);
+    verify(delegate).onProposerSlashing(proposerSlashing);
     verifyNoInteractions(validatorIndexProvider);
     verifyNoInteractions(statusLogger);
   }