Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add interop keystores and passwords so that we can use interop keys to generate genesis outside of interop mode #4889

Merged
merged 2 commits into from
Jan 21, 2022
Merged

add interop keystores and passwords so that we can use interop keys to generate genesis outside of interop mode #4889

merged 2 commits into from
Jan 21, 2022

Conversation

rolfyone
Copy link
Contributor

@rolfyone rolfyone commented Jan 21, 2022 •
edited
Loading

Signed-off-by: Paul Harris [email protected]

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@rolfyone
add interop keystores and passwords so that we can use interop keys t…
ae202a9 
…o generate genesis outside of interop mode.

Signed-off-by: Paul Harris <[email protected]>
ajsutton
ajsutton approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any reason to have these hidden so far down the source tree. I'd probably just create a new top level interop-keys directory so they're easy to find.

@rolfyone rolfyone enabled auto-merge (squash) January 21, 2022 05:54
@rolfyone rolfyone merged commit 3607680 into Consensys:master Jan 21, 2022
@rolfyone rolfyone deleted the add-interop-keys branch January 21, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolfyone @ajsutton