Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge] unhide --Xvalidators-proposer-* #5153

Merged
merged 6 commits into from
Mar 10, 2022
Merged

[Merge] unhide --Xvalidators-proposer-* #5153

merged 6 commits into from
Mar 10, 2022

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Mar 10, 2022

PR Description

unhide --Xvalidators-proposer-*

Fixed Issue(s)

#4874

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

ajsutton
ajsutton approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more to unhide please:

 @Option(
      hidden = true,
      names = {"--ee-jwt-secret-file"},

but LGTM otherwise. :)

@tbenr
Copy link
Contributor Author

tbenr commented Mar 10, 2022

One more to unhide please:

oh gosh is on the top 😭

@tbenr tbenr enabled auto-merge (squash) March 10, 2022 14:58
@tbenr tbenr merged commit a5f15f4 into Consensys:master Mar 10, 2022
@tbenr tbenr deleted the unhide_merge_cli_options branch March 10, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @ajsutton