Removes all usages of UnsignedLong usage and changes to long. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhila-raju
changed the title
akhila-raju
changed the title
benjaminion
reviewed
Apr 4, 2019
ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/Constants.java
Outdated
Show resolved
Hide resolved
jrhea
reviewed
Apr 4, 2019
...atetransition/src/main/java/tech/pegasys/artemis/statetransition/util/SlotProcessorUtil.java
Show resolved
Hide resolved
jrhea
reviewed
Apr 4, 2019
ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/Constants.java
Outdated
Show resolved
Hide resolved
schroedingerscode
previously requested changes
Apr 5, 2019
There was a problem hiding this comment.
A number of concerns about index out of bounds errors, loss of precision, and order of operations. I've still yet to review BlockProcessorUtil, AttestationUtil, BeaconStateUtil, and BeaconState, which I will do after the v0.5.1 upgrade, however I expect they will have similar issues.
ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/Constants.java
Outdated
Show resolved
Hide resolved
ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/Constants.java
Outdated
Show resolved
Hide resolved
ethereum/datastructures/src/main/java/tech/pegasys/artemis/datastructures/Constants.java
Outdated
Show resolved
Hide resolved
...tures/src/main/java/tech/pegasys/artemis/datastructures/operations/SlashableAttestation.java
Outdated
Show resolved
Hide resolved
...tures/src/main/java/tech/pegasys/artemis/datastructures/operations/SlashableAttestation.java
Outdated
Show resolved
Hide resolved
...tetransition/src/main/java/tech/pegasys/artemis/statetransition/util/EpochProcessorUtil.java
Outdated
Show resolved
Hide resolved
...tetransition/src/main/java/tech/pegasys/artemis/statetransition/util/EpochProcessorUtil.java
Outdated
Show resolved
Hide resolved
...tetransition/src/main/java/tech/pegasys/artemis/statetransition/util/EpochProcessorUtil.java
Outdated
Show resolved
Hide resolved
...tetransition/src/main/java/tech/pegasys/artemis/statetransition/util/EpochProcessorUtil.java
Outdated
Show resolved
Hide resolved
...tetransition/src/main/java/tech/pegasys/artemis/statetransition/util/EpochProcessorUtil.java
Show resolved
Hide resolved
Co-Authored-By: akhila-raju <[email protected]>
schroedingerscode
suggested changes
Apr 12, 2019
...m/datastructures/src/main/java/tech/pegasys/artemis/datastructures/util/BeaconStateUtil.java
Outdated
Show resolved
Hide resolved
...m/datastructures/src/main/java/tech/pegasys/artemis/datastructures/util/BeaconStateUtil.java
Outdated
Show resolved
Hide resolved
...m/datastructures/src/main/java/tech/pegasys/artemis/datastructures/util/BeaconStateUtil.java
Outdated
Show resolved
Hide resolved
...tetransition/src/main/java/tech/pegasys/artemis/statetransition/util/EpochProcessorUtil.java
Outdated
Show resolved
Hide resolved
schroedingerscode
approved these changes
Apr 22, 2019
* Move from Cava to Apache Tuweni * Add snapshots repository even when building with jenkins
…es header to specify the datatype (Consensys#599)
* Fixed attestation typo AND am now using the return result from plumb tree of the message hash * changing message_type to attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Removes all usages of UnsignedLong usage and changes to long.
Fixed Issue(s)
Fixes #312.