teku-6320 Capella helper functions #6403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../src/main/java/tech/pegasys/teku/spec/logic/versions/capella/helpers/MiscHelpersCapella.java
Fixed
Show fixed
Hide fixed
.../src/main/java/tech/pegasys/teku/spec/logic/versions/capella/helpers/MiscHelpersCapella.java
Fixed
Show fixed
Hide fixed
.../src/main/java/tech/pegasys/teku/spec/logic/versions/capella/helpers/MiscHelpersCapella.java
Fixed
Show fixed
Hide fixed
.../src/main/java/tech/pegasys/teku/spec/logic/versions/capella/helpers/MiscHelpersCapella.java
Fixed
Show fixed
Hide fixed
.../src/main/java/tech/pegasys/teku/spec/logic/versions/capella/helpers/MiscHelpersCapella.java
Fixed
Show fixed
Hide fixed
.../src/main/java/tech/pegasys/teku/spec/logic/versions/capella/helpers/MiscHelpersCapella.java
Fixed
Show fixed
Hide fixed
lucassaldanha
force-pushed
the
capella-helpers
branch
from
f63f99a to
fa6b8a8
Compare
rolfyone
reviewed
Nov 9, 2022
Comment on lines
+47
to
+59
| @Test | ||
| public void isFullyWithdrawableValidatorShouldReturnTrueForEligibleValidator() { | ||
| final Validator validator = | ||
| dataStructureUtil | ||
| .randomValidator() | ||
| .withWithdrawalCredentials(eth1WithdrawalsCredentials) | ||
| .withWithdrawableEpoch(UInt64.ZERO); | ||
|
|
||
| final UInt64 balance = UInt64.ONE; | ||
| final UInt64 epoch = UInt64.ONE; | ||
|
|
||
| assertThat(miscHelpersCapella.isFullyWithdrawableValidator(validator, balance, epoch)).isTrue(); | ||
| } |
There was a problem hiding this comment.
this does look like an excellent use case for @ParameterizedTest
if we drove it via balance, epoch, withdrawableEpoch, expectation, then you'd have 1 set of code...
rolfyone
reviewed
Nov 9, 2022
Comment on lines
+1595
to
+1598
| public Bytes32 randomEth1WithdrawalCredentials() { | ||
| return Bytes32.wrap( | ||
| Bytes.concatenate(Bytes.fromHexString("0x01"), randomBytes32().slice(0, 31))); | ||
| } |
There was a problem hiding this comment.
eth1 withdrawal credentials are slightly different...
private static final Bytes ETH1_WITHDRAWAL_PREFIX = Bytes.fromHexString("0x01");
private static final Bytes WITHDRAWAL_BUFFER = Bytes.repeat((byte) 0x00, 11);
public static Bytes32 withdrawalAddressFromEth1Address(final Bytes20 toExecutionAddress) {
return Bytes32.wrap(
Bytes.concatenate(
ETH1_WITHDRAWAL_PREFIX, WITHDRAWAL_BUFFER, toExecutionAddress.getWrappedBytes()));
}
above is a snippet from my current work, where I'll create an eth1 address, we can probably migrate this into helpers after, but maybe for this one just make the Bytes32.wrap(Bytes.fromHexString("0x010000000000000000000000"), randomEth1Address())) or something...
rolfyone
approved these changes
Nov 9, 2022
| import tech.pegasys.teku.spec.datastructures.state.Validator; | ||
| import tech.pegasys.teku.spec.util.DataStructureUtil; | ||
|
|
||
| class MiscHelpersCapellaTest { |
Check notice
Code scanning / CodeQL
Unused classes and interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implemented helper predicate functions:
Reference: Cappella beacon chain spec
Fixed Issue(s)
fixes #6320
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog