Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement forward multipeer sync for EIP-4844 #6684

Merged

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Jan 13, 2023

PR Description

  • Modified SyncSourceBatch to cache the blobs sidecars for a batch
  • Modified BatchImported to store blobs sidecars ahead of block import

Tested syncing to mainnet with stub EL, so current flow seems not affected.

Fixed Issue(s)

fixes #6669

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov force-pushed the 4844_forward_multipeer_sync branch from 630162b to 19b3986 Compare January 16, 2023 12:06
@StefanBratanov StefanBratanov marked this pull request as ready for review January 16, 2023 13:39
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just a suggestion on debug messages

@StefanBratanov StefanBratanov merged commit 3cf52b1 into Consensys:master Jan 16, 2023
@StefanBratanov StefanBratanov deleted the 4844_forward_multipeer_sync branch January 16, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Forward Sync for EIP-4844
2 participants