Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert historical and recent block fetching for coupled blobs #6915

Merged
merged 7 commits into from
Mar 8, 2023
Merged

Revert historical and recent block fetching for coupled blobs #6915

merged 7 commits into from
Mar 8, 2023

Conversation

StefanBratanov
Copy link
Contributor

PR Description

  • Removed all usages of requestBlockAndBlobsSidecarByRoot in Eth2Peer
  • Reverted to the old way of historical and recent block sync with few small changes
  • Renamed FetchBlockTaskFactory to FetchTaskFactory, so it can be reused for BlobSidecar fetching.
  • Created AbstractFetchTask which can also be reused to findRandomPeer

Fixed Issue(s)

one of tasks in #6822

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov force-pushed the revert_coupled_blobs_sync branch from 7e1737a to d6fc6ad Compare March 8, 2023 09:35
tbenr
tbenr approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov force-pushed the revert_coupled_blobs_sync branch from d6fc6ad to a4f489e Compare March 8, 2023 17:36
@StefanBratanov StefanBratanov enabled auto-merge (squash) March 8, 2023 17:38
@StefanBratanov StefanBratanov disabled auto-merge March 8, 2023 17:51
@StefanBratanov StefanBratanov enabled auto-merge (squash) March 8, 2023 17:51
@StefanBratanov StefanBratanov merged commit 47f35fa into Consensys:master Mar 8, 2023
tbenr pushed a commit to tbenr/teku that referenced this pull request Mar 15, 2023
@StefanBratanov @tbenr
Revert historical and recent block fetching for coupled blobs (Consen…
17b7f08 
…sys#6915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @tbenr