Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert forward sync for coupled blobs #6931

Conversation

StefanBratanov
Copy link
Contributor

PR Description

  • Removed the blobs sidecars retrieval in forward syncing for both single and multi peer
  • Main changes are in SyncSourceBatch and in PeerSync
  • Moved the isStorageOfBlobsSidecarsRequiredAtSlot() from the BlobsSidecarManager into the spec

Fixed Issue(s)

resolves a task in #6822

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a nit

@StefanBratanov StefanBratanov force-pushed the revert_forward_sync_coupled_blobs branch from e2e1f7e to 29b149d Compare March 10, 2023 16:41
@StefanBratanov StefanBratanov merged commit e1505fb into Consensys:master Mar 10, 2023
@StefanBratanov StefanBratanov deleted the revert_forward_sync_coupled_blobs branch March 10, 2023 17:19
tbenr pushed a commit to tbenr/teku that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants