Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get new block (BlockContents) #7044

Merged
merged 5 commits into from
Apr 19, 2023

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Apr 17, 2023

PR Description

Create unsigned new BlockContents in /eth/v2/validator/blocks/{slot} endpoint post Deneb

Fixed Issue(s)

#7019

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi changed the title 7019 get new block Get new block (BlockContents) Apr 17, 2023
@mehdi-aouadi mehdi-aouadi self-assigned this Apr 17, 2023
@mehdi-aouadi mehdi-aouadi added the Epic Deneb Issues required to implement Deneb upgrade label Apr 17, 2023
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but just need to do one more focused review tomorrow, possibly after merging the other PR to make this one easier.

Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) April 19, 2023 15:13
@mehdi-aouadi mehdi-aouadi merged commit 72d8467 into Consensys:master Apr 19, 2023
@mehdi-aouadi mehdi-aouadi deleted the 7019-get-new-block branch April 19, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Deneb Issues required to implement Deneb upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants