Get block Deneb #7055
Closed
Get block Deneb #7055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
force-pushed
the
7048-get-block-deneb
branch
from
59f9b68 to
2db4b47
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/GetBlock.java
Fixed
Show resolved
Hide resolved
mehdi-aouadi
force-pushed
the
7048-get-block-deneb
branch
3 times, most recently
from
e14bf84 to
4e125b1
Compare
mehdi-aouadi
force-pushed
the
7048-get-block-deneb
branch
from
4e125b1 to
5461d09
Compare
|
@mehdi-aouadi I don't think this is actually correct. The api is not part of the signing flow. So to get blobs there will be a dedicated API (#6781) and this one will keep returning just blocks |
Yep we figured that out with @zilm13 yesterday. I will probably close this one and get to it later (There won't be this much changes since we will return the BeaconBlock without blobs) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implement Deneb
GetBlockAPIFixed Issue(s)
#7048
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog