Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge getPayloadV3 and getBlobsBundleV1 (part 1) #7096

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 3, 2023

PR Description

Spec Reference: ethereum/execution-apis#402

  • Remove getBlobsBundleV1 method in ExecutionEngineClient and ExecutionLayerChannel
  • Changed BlobsBundleV1 jackson object to match the structure in the spec
  • Modified the internal BlobsBundle

Left for part 2:

  • Return BlobsBundle alongside the ExecutionPayload in the ExecutionLayerChannel and the ExecutionClientHandler
  • Fix couple of TODOs
  • Modify the ExecutionLayerBlockProductionManagerImpl to not use the BLOBS_BUNDLE_DUMMY
  • Modify the ExecutionLayerChannelStub

Fixed Issue(s)

will fix task in #6822 when part 2 is complete

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov force-pushed the merge_get_payload_get_blobs_bundle branch from eab16d2 to 1507393 Compare May 3, 2023 13:09
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr
Copy link
Contributor

tbenr commented May 4, 2023

I'd track the fact that we want the Stub to work properly. Maybe part of part2 or on a separate PR

@StefanBratanov
Copy link
Contributor Author

I'd track the fact that we want the Stub to work properly. Maybe part of part2 or on a separate PR

Good point. Added it as a point here. And will tackle in the second part.

@StefanBratanov StefanBratanov merged commit 8549bcf into Consensys:master May 4, 2023
@StefanBratanov StefanBratanov deleted the merge_get_payload_get_blobs_bundle branch May 4, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants