BlobSidecar pool immediate fetch for non-current-slot + prepare for data unavailable retry #7103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenr
force-pushed
the
complete_block_import_logic
branch
from
4213f30 to
fb8fd4f
Compare
tbenr
changed the title
zilm13
approved these changes
May 8, 2023
| @@ -384,7 +380,7 @@ Optional<Duration> calculateFetchDelay(final SlotAndBlockRoot slotAndBlockRoot) | |||
| final UInt64 finalTime = | |||
| targetMillis.min(upperLimitRelativeToAttDue).max(nowMillis.plus(MIN_WAIT_MILLIS)); | |||
|
|
|||
| return Optional.of(Duration.ofMillis(finalTime.minus(nowMillis).intValue())); | |||
| return Duration.ofMillis(finalTime.minus(nowMillis).intValue()); | |||
There was a problem hiding this comment.
I'm not sure but maybe we need to protect it there with minusMinZero?
There was a problem hiding this comment.
Well, time provider should be guaranteed to be monotonic
...transition/src/test/java/tech/pegasys/teku/statetransition/util/BlobSidecarPoolImplTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onBlobSidecarsFromSyncmethod toonCompletedBlockAndBlobSidecars, moving away from flow-based name to a feature-based oneFAILED_DATA_AVAILABILITY_CHECKblock import failure in two reasons:FAILED_DATA_AVAILABILITY_CHECK_INVALID: data was there but validation failedFAILED_DATA_AVAILABILITY_CHECK_NOT_AVAILABLE: data wasn't availableThe "not available" one will be used to trigger a retry (on a dedicated PR)
related to #7112
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog