add block container #7126
Merged
add block container #7126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
force-pushed
the
7019-refactor-deneb-containers
branch
from
1fd06cb to
56ee89c
Compare
mehdi-aouadi
force-pushed
the
7019-refactor-deneb-containers
branch
from
56ee89c to
2c43635
Compare
rolfyone
approved these changes
May 10, 2023
mehdi-aouadi
force-pushed
the
7019-refactor-deneb-containers
branch
from
29695d0 to
2a44aaf
Compare
|
yeah.. like it. Thanks @rolfyone for the idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add a common
BlockContainerto avoid manipulating unknownObjectin the block creation APIsFixed Issue(s)
#7019
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog