-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Decoupling] Block and blob sidecars production for Deneb (part 1) #7129
Merged
StefanBratanov
merged 23 commits into
Consensys:master
from
StefanBratanov:block_and_blob_sidecars_production_deneb
May 19, 2023
Merged
[Decoupling] Block and blob sidecars production for Deneb (part 1) #7129
StefanBratanov
merged 23 commits into
Consensys:master
from
StefanBratanov:block_and_blob_sidecars_production_deneb
May 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
force-pushed
the
block_and_blob_sidecars_production_deneb
branch
3 times, most recently
from
May 15, 2023 15:07
e0ec4fd
to
92dde00
Compare
StefanBratanov
changed the title
[Decoupling] Block and blob sidecars production for Deneb
[Decoupling] Block and blob sidecars production for Deneb (part 1)
May 15, 2023
StefanBratanov
force-pushed
the
block_and_blob_sidecars_production_deneb
branch
from
May 16, 2023 15:36
060d3c0
to
0a82e58
Compare
StefanBratanov
force-pushed
the
block_and_blob_sidecars_production_deneb
branch
5 times, most recently
from
May 19, 2023 08:00
dd40c51
to
477a103
Compare
…g via the validator api channel
StefanBratanov
force-pushed
the
block_and_blob_sidecars_production_deneb
branch
from
May 19, 2023 10:43
35b7a75
to
781efca
Compare
tbenr
approved these changes
May 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a couple of ideas
.../src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/validator/GetNewBlindedBlock.java
Outdated
Show resolved
Hide resolved
...restapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/validator/GetNewBlock.java
Outdated
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
In this PR (part 1) will focus on:
sendSignedBlock
fromSignedBeaconBlock
toSignedBlockContainer
and the return type ofcreateUnsignedBlock
toBlockContainer
.BlockPublisherDeneb
BlockContainer
andSignedBlockContainer
to simplify data structures.BlockContainer
andSignedBlockContainer
to extendSszData
createUnsignedBlindedBlockContents
andcreateUnsignedBlockContents
fromValidatorApiChannel
since one method would be used for both pre-Deneb and post-DenebcreateUnsignedBlock
to use the returnedBlockContainer
inFailoverValidatorApiHandler
when determining if block is blinded in order to put it in the cache.blindedBlockContentsSchema
andsignedBlindedBlockContentsSchema
inSchemaDefinitionsDeneb
to use the beacon block blinded schema instead of the non blinded oneFixed Issue(s)
when next parts are done, it will fix couple of tasks in #6822
Documentation
doc-change-required
label to this PR if updates are required.Changelog