Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decoupling] Block and blob sidecars production for Deneb (part 1) #7129

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented May 10, 2023

PR Description

In this PR (part 1) will focus on:

  • changing the parameter of sendSignedBlock from SignedBeaconBlock to SignedBlockContainer and the return type of createUnsignedBlock to BlockContainer.
  • Implement the BlockPublisherDeneb
  • Separate BlockContainer and SignedBlockContainer to simplify data structures.
  • Change BlockContainer and SignedBlockContainer to extend SszData
  • Remove createUnsignedBlindedBlockContents and createUnsignedBlockContents from ValidatorApiChannel since one method would be used for both pre-Deneb and post-Deneb
  • Changed createUnsignedBlock to use the returned BlockContainer in FailoverValidatorApiHandler when determining if block is blinded in order to put it in the cache.
  • Fixed blindedBlockContentsSchema and signedBlindedBlockContentsSchema in SchemaDefinitionsDeneb to use the beacon block blinded schema instead of the non blinded one

Fixed Issue(s)

when next parts are done, it will fix couple of tasks in #6822

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov force-pushed the block_and_blob_sidecars_production_deneb branch 3 times, most recently from e0ec4fd to 92dde00 Compare May 15, 2023 15:07
@StefanBratanov StefanBratanov changed the title [Decoupling] Block and blob sidecars production for Deneb [Decoupling] Block and blob sidecars production for Deneb (part 1) May 15, 2023
@StefanBratanov StefanBratanov force-pushed the block_and_blob_sidecars_production_deneb branch from 060d3c0 to 0a82e58 Compare May 16, 2023 15:36
@StefanBratanov StefanBratanov marked this pull request as ready for review May 16, 2023 15:41
@StefanBratanov StefanBratanov force-pushed the block_and_blob_sidecars_production_deneb branch 5 times, most recently from dd40c51 to 477a103 Compare May 19, 2023 08:00
@StefanBratanov StefanBratanov force-pushed the block_and_blob_sidecars_production_deneb branch from 35b7a75 to 781efca Compare May 19, 2023 10:43
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of ideas

@StefanBratanov StefanBratanov enabled auto-merge (squash) May 19, 2023 12:53
@StefanBratanov StefanBratanov merged commit 5502f7e into Consensys:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants