-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed blob sidecars directly under blob_sidecars property in BlockContents #7145
Merged
mehdi-aouadi
merged 6 commits into
Consensys:master
from
mehdi-aouadi:fix-block-contents-schema
May 16, 2023
Merged
Embed blob sidecars directly under blob_sidecars property in BlockContents #7145
mehdi-aouadi
merged 6 commits into
Consensys:master
from
mehdi-aouadi:fix-block-contents-schema
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
force-pushed
the
fix-block-contents-schema
branch
2 times, most recently
from
May 15, 2023 09:26
be06dad
to
8b42a49
Compare
mehdi-aouadi
force-pushed
the
fix-block-contents-schema
branch
from
May 15, 2023 12:29
05b7d5a
to
475cb45
Compare
tbenr
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/deneb/BlockContents.java
Show resolved
Hide resolved
tbenr
reviewed
May 16, 2023
data/serializer/src/main/java/tech/pegasys/teku/api/schema/deneb/SignedBlockContents.java
Show resolved
Hide resolved
tbenr
reviewed
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks generally ok. just a couple of renamings
tbenr
approved these changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Remove redundant
blob_sidecars
property name inBlockContents
container. This means removing theBlobSidecars
container and itsBlobSidecarsSchema
(Same for the signed and the signed, blinded ones).Blob sidecars should be represented as an array under the
blob_sidecars
property inBlockContents
.In the current implementation there is a redundant
blob_sidecars
property:BlockContents
:These changes fixes it to become:
These changes also fix
SignedBlockContents
,BlindedBlockContents
andSignedBlindedBlockContents
Spec reference here
Fixed Issue(s)
Documentation
doc-change-required
label to this PR if updates are required.Changelog