Add kzg reference tests support #7571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassaldanha
approved these changes
Oct 3, 2023
| import tech.pegasys.teku.spec.config.SpecConfigDeneb; | ||
|
|
||
| public abstract class KzgTestExecutor implements TestExecutor { | ||
| // We don't support config reloading and all tests are currently for mainnet |
There was a problem hiding this comment.
Is this something we want to support in the future? If it is, it would be good to have a ticket for it linked here.
There was a problem hiding this comment.
- We may need it not only here, Stefan is already following it for another PR Support Deneb fork choice reference tests #7541
- There are no kzg reference tests other than for
mainnetat the moment, if they are added we start to fail and will notice it - Currently config type is part of the directory name and extracting it looks ugly, so I removed it and harcoded "mainnet". It's not an issue until minimal are added (see №2)
| actualVerificationResult = | ||
| CKZG4844 | ||
| .getInstance() | ||
| .verifyBlobKzgProofBatch(List.of(blob), List.of(commitment), List.of(proof)); |
There was a problem hiding this comment.
Could you please add a comment that we are using the batch verify because we don't have a "non-batch" implementation? Just to avoid confusion.
There was a problem hiding this comment.
It's in KzgTests, I will duplicate it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
Fixes #6969
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog