Remove deprecated methods from (Signed)BlockContainer #7700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
beacon/sync/src/main/java/tech/pegasys/teku/beacon/sync/forward/multipeer/BatchImporter.java
Dismissed
Show dismissed
Hide dismissed
beacon/sync/src/main/java/tech/pegasys/teku/beacon/sync/forward/singlepeer/PeerSync.java
Dismissed
Show dismissed
Hide dismissed
| @@ -250,7 +250,7 @@ | |||
|
|
|||
| private void blobSidecarsImportedSuccessfully( | |||
| final SignedBeaconBlock block, final List<BlobSidecarOld> blobSidecars) { | |||
| verify(blobSidecarPool).onCompletedBlockAndBlobSidecars(block, blobSidecars); | |||
| verify(blobSidecarPool).onCompletedBlockAndBlobSidecarsOld(block, blobSidecars); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
beacon/sync/src/test/java/tech/pegasys/teku/beacon/sync/forward/singlepeer/PeerSyncTest.java
Dismissed
Show dismissed
Hide dismissed
...m/statetransition/src/main/java/tech/pegasys/teku/statetransition/blobs/BlobSidecarPool.java
Dismissed
Show dismissed
Hide dismissed
...m/statetransition/src/main/java/tech/pegasys/teku/statetransition/blobs/BlobSidecarPool.java
Dismissed
Show dismissed
Hide dismissed
...n/validator/src/test/java/tech/pegasys/teku/validator/coordinator/BlockFactoryDenebTest.java
Show resolved
Hide resolved
mehdi-aouadi
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
SignedBlockContainerandBlockContaineronCompletedBlockAndBlobSidecarstoBlobSidecarPoolFixed Issue(s)
helps with block production/publishing flow for #7654
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog