Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AbstractBlockPublisher to simplify blob sidecars publishing #7710

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Refactor AbstractBlockPublisher to simplify blob sidecars publishing #7710

merged 4 commits into from
Nov 16, 2023

Conversation

StefanBratanov
Copy link
Contributor

PR Description

  • Changed BlockFactory.unblindSignedBlockIfBlinded to accept and return SignedBeaconBlock and use same implementation for Phase0, Deneb
  • Changed AbstractBlockPublisher and its implementations to import and publish block and blob sidecars separately
  • The other changes are mostly in tests

Fixed Issue(s)

helps with block publishing flow for #7654

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov force-pushed the block_publisher_refactor branch from 887df1f to b448d74 Compare November 15, 2023 11:29
zilm13
zilm13 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes, it's more clear now in line with spec changes.
Just some nits

...alidator/src/main/java/tech/pegasys/teku/validator/coordinator/publisher/BlockPublisher.java Show resolved Hide resolved
...tor/src/main/java/tech/pegasys/teku/validator/coordinator/publisher/BlockPublisherDeneb.java Show resolved Hide resolved
beacon/validator/src/main/java/tech/pegasys/teku/validator/coordinator/BlockFactoryPhase0.java Outdated Show resolved Hide resolved
ethereum/spec/src/testFixtures/java/tech/pegasys/teku/spec/util/DataStructureUtil.java Outdated Show resolved Hide resolved
.../test/java/tech/pegasys/teku/validator/coordinator/publisher/AbstractBlockPublisherTest.java Show resolved Hide resolved
@StefanBratanov StefanBratanov force-pushed the block_publisher_refactor branch from f80e9bc to a88dcfb Compare November 16, 2023 10:05
@StefanBratanov StefanBratanov merged commit ce633ad into Consensys:master Nov 16, 2023
4 checks passed
@StefanBratanov StefanBratanov deleted the block_publisher_refactor branch November 16, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilm13 zilm13 zilm13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @zilm13