Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to GET validators from state on 400 POST response #7842

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Dec 18, 2023

PR Description

We are handling fallback to GET validators from state on status codes 404 and 405 in #7786, but LH seems to be returning 400, so handling that case as well, which should cover all scenarios.

│ teku java.util.concurrent.CompletionException: tech.pegasys.teku.validator.remote.FailoverRequestException: Remote request (get_validator_statuses) failed on all configured Beacon Node endpoints 
│ teku ...: java.lang.IllegalArgumentException: Invalid params response from Beacon Node API (url = ...)
│ ...:5051/eth/v1/beacon/states/head/validators, status = 400, message = BAD_REQUEST: Unsupported endpoint version: v1)

Also add flag --Xuse-post-validators-endpoint-enabled until all clients implement this endpoint.

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 2d3af8b into Consensys:master Dec 18, 2023
15 checks passed
@StefanBratanov StefanBratanov deleted the fallback_get_validators_from_state_on_400 branch December 19, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants