Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix post block endpoints returning 202 in case of unexpected errors #7850

Merged
merged 4 commits into from
Dec 22, 2023
Merged

Fix post block endpoints returning 202 in case of unexpected errors #7850

merged 4 commits into from
Dec 22, 2023

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Dec 22, 2023 •
edited
Loading

PR Description

Fixes following:

The PR makes will make unblinding (and any other unexpected error) return 500. Unblinding is done before validation, so 500 makes more sense in my opinion.

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

zilm13
zilm13 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) December 22, 2023 13:39
@StefanBratanov StefanBratanov merged commit 5f5bb78 into Consensys:master Dec 22, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilm13 zilm13 zilm13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @zilm13