Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VC slashing Part 1 - Refactoring slashing risk actions #7913

Merged
merged 2 commits into from
Jan 24, 2024
Merged

VC slashing Part 1 - Refactoring slashing risk actions #7913

merged 2 commits into from
Jan 24, 2024

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Jan 24, 2024 •
edited
Loading

PR Description

Validator Slashing Part 1:
Refactor DoppelgangerDetectionAction to reuse it for the validator slashing

Fixed Issue(s)

#7707

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi self-assigned this Jan 24, 2024
@mehdi-aouadi mehdi-aouadi changed the title refactoring slashing risk actions VC slashing Part 1 - Refactoring slashing risk actions Jan 24, 2024
@mehdi-aouadi mehdi-aouadi mentioned this pull request Jan 24, 2024
Closed
2 tasks
zilm13
zilm13 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) January 24, 2024 15:53
@mehdi-aouadi mehdi-aouadi merged commit c2e9bb5 into Consensys:master Jan 24, 2024
14 of 15 checks passed
@rolfyone
Copy link
Contributor

much better :) thanks

@mehdi-aouadi mehdi-aouadi deleted the 7707-1-slashing-risk-refactoring branch February 17, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilm13 zilm13 zilm13 approved these changes

@rolfyone rolfyone Awaiting requested review from rolfyone

Assignees

@mehdi-aouadi mehdi-aouadi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehdi-aouadi @rolfyone @zilm13