Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VC slashing Part 4 - vc slashing validator timing actions #7916

Merged
merged 2 commits into from
Jan 25, 2024
Merged

VC slashing Part 4 - vc slashing validator timing actions #7916

merged 2 commits into from
Jan 25, 2024

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Jan 24, 2024 •
edited
Loading

PR Description

Validator Slashing Part 4:
Implement ValidatorTimingActions (handle attester and proposer slashing events)

Fixed Issue(s)

#7707

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi self-assigned this Jan 24, 2024
@mehdi-aouadi mehdi-aouadi force-pushed the 7707-4-vc-slashing-valitor-timing-actions branch from fcb9e5c to 1502593 Compare January 24, 2024 11:41
@mehdi-aouadi mehdi-aouadi mentioned this pull request Jan 24, 2024
Closed
2 tasks
@mehdi-aouadi mehdi-aouadi force-pushed the 7707-4-vc-slashing-valitor-timing-actions branch 2 times, most recently from dd1b5da to 76fad39 Compare January 24, 2024 16:20
rolfyone
rolfyone approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, probably worth a couple of basic tests around the ValidatorIndexProvider new interface in case we ever refactor. Its indirectly covered but directly covered would be clearer if we ever break it...

@mehdi-aouadi mehdi-aouadi force-pushed the 7707-4-vc-slashing-valitor-timing-actions branch from 58140e4 to c1e2018 Compare January 25, 2024 11:01
@mehdi-aouadi mehdi-aouadi merged commit 55985a3 into Consensys:master Jan 25, 2024
15 checks passed
@mehdi-aouadi mehdi-aouadi deleted the 7707-4-vc-slashing-valitor-timing-actions branch January 25, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees

@mehdi-aouadi mehdi-aouadi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mehdi-aouadi @rolfyone