VC slashing part 5 - vc slashing sse #7917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
changed the title
mehdi-aouadi
force-pushed
the
7707-5-vc-slashing-sse
branch
from
9806cd6 to
40dc60b
Compare
2 tasks
mehdi-aouadi
force-pushed
the
7707-5-vc-slashing-sse
branch
from
40dc60b to
53e1508
Compare
mehdi-aouadi
force-pushed
the
7707-5-vc-slashing-sse
branch
from
53e1508 to
80dda7a
Compare
rolfyone
reviewed
Jan 25, 2024
Comment on lines
+139
to
+144
| if (shutdownWhenValidatorSlashedEnabled) { | ||
| eventTypes.add(EventType.attester_slashing); | ||
| eventTypes.add(EventType.proposer_slashing); | ||
| } |
There was a problem hiding this comment.
ideally test case here to so we don't regress...
mehdi-aouadi
force-pushed
the
7707-5-vc-slashing-sse
branch
from
476f850 to
9fb58ea
Compare
rolfyone
reviewed
Jan 31, 2024
...a/tech/pegasys/teku/validator/remote/eventsource/EventSourceBeaconChainEventAdapterTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Validator Slashing Part 5:
Handle
attester_slashingandproposer_slashingevents and subscribe to them only when theXshut-down-when-validator-slashed-enabledoption is set to trueFixed Issue(s)
#7707
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog