Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC slashing Part 7 - vc slashing finals #7919

Merged
merged 6 commits into from
Feb 4, 2024

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Jan 24, 2024

PR Description

Add missing finals

Fixed Issue(s)

#7707

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi self-assigned this Jan 24, 2024
@mehdi-aouadi mehdi-aouadi force-pushed the 7707-7-vc-slashing-finals branch from 3b615ec to 171bf84 Compare January 24, 2024 11:43
@mehdi-aouadi mehdi-aouadi force-pushed the 7707-7-vc-slashing-finals branch 2 times, most recently from 2efe0c3 to 9834aca Compare January 24, 2024 16:21
@rolfyone
Copy link
Contributor

caveat - if this didn't build on anything it'd probably be a trivial review, but i'll wait for the built up reviews to clear and it should be easy...

@mehdi-aouadi mehdi-aouadi force-pushed the 7707-7-vc-slashing-finals branch 6 times, most recently from ff01c48 to ec8c429 Compare February 2, 2024 09:53
@mehdi-aouadi mehdi-aouadi force-pushed the 7707-7-vc-slashing-finals branch from ec8c429 to c598b14 Compare February 2, 2024 12:25
@mehdi-aouadi mehdi-aouadi requested a review from rolfyone February 2, 2024 12:25
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolfyone rolfyone merged commit 4d98027 into Consensys:master Feb 4, 2024
15 checks passed
@mehdi-aouadi mehdi-aouadi deleted the 7707-7-vc-slashing-finals branch February 5, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants