Updated sendValidatorLiveness to use typedef client #8498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also followed suit of the last PR that didn't persist request objects, and created a cache, although we probably want to share an existing one... initially this is probably going in the right direction... partially addresses Consensys#7762 Signed-off-by: Paul Harris <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updated the validator liveness functionality to use the typedef client, improving consistency and maintainability.
validator/remote/src/main/java/tech/pegasys/teku/validator/remote/typedef/OkHttpValidatorTypeDefClient.java: AddedsendValidatorsLivenessmethod; removed request object persistence.validator/remote/src/main/java/tech/pegasys/teku/validator/remote/RemoteValidatorApiHandler.java: Updated to useOkHttpValidatorTypeDefClientforgetValidatorsLiveness.validator/remote/src/main/java/tech/pegasys/teku/validator/remote/apiclient/ValidatorRestApiClient.java: RemovedsendValidatorsLivenessmethod.validator/remote/src/main/java/tech/pegasys/teku/validator/remote/typedef/handlers/SendValidatorLivenessRequest.java: New handler for validator liveness requests.validator/remote/src/test/java/tech/pegasys/teku/validator/remote/RemoteValidatorApiHandlerTest.java: Updated tests to usetypeDefClientfor validator liveness requests.
14 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
lucassaldanha
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also followed suit of the last PR that didn't persist request objects, and created a cache, although we probably want to share an existing one... initially this is probably going in the right direction...
partially addresses #7762
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog