Post aggregate and proofs request #8523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the SendAggregateAndProofsRequest to support the new PostAggregateAndProofsV2 API for the Electra milestone, implementing EIP-7549. Key changes include:
- Added support for different SpecMilestones in SendAggregateAndProofsRequest and SendSignedAttestationsRequest
- Introduced separate methods for pre-Electra and post-Electra submissions in both request handlers
- Added consensus version header for post-Electra requests
- Updated ValidatorApiMethod enum with new V2 endpoints for signed attestations and aggregate proofs
- Modified OkHttpValidatorTypeDefClient to include 'spec' parameter in relevant methods
- Updated AbstractTypeDefRequest to support additional headers in postJson method
- Added new integration tests for Electra milestone in SendSignedAttestationsRequestElectraTest
- Updated existing tests to accommodate new changes and improve specificity
These changes ensure compatibility with both pre-Electra and Electra milestones, aligning with EIP-7549 implementation requirements.
13 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
50
to
51
| @TestTemplate | ||
| public void getAggregateAttestation_makesExpectedRequest() throws Exception { |
There was a problem hiding this comment.
logic: Method name doesn't match its functionality
mehdi-aouadi
force-pushed
the
8439-request
branch
from
29a772a to
bf40b3d
Compare
mehdi-aouadi
force-pushed
the
8439-request
branch
from
bf40b3d to
4571823
Compare
…estationsRequest class - removed an endpoint that had 1 usage in the AbstractTypeDefRequest class- if we're adding a parameter to a fn thats used in one place i'd prefer we dont make a new fn. - new test class for electra attestations (renamed the post test class) Signed-off-by: Paul Harris <[email protected]>
…estationsRequest class - removed an endpoint that had 1 usage in the AbstractTypeDefRequest class- if we're adding a parameter to a fn thats used in one place i'd prefer we dont make a new fn. - new test class for electra attestations (renamed the post test class) Signed-off-by: Paul Harris <[email protected]>
mehdi-aouadi
force-pushed
the
8439-request
branch
from
4571823 to
9e23c33
Compare
tbenr
reviewed
Aug 28, 2024
...or/remote/src/main/java/tech/pegasys/teku/validator/remote/apiclient/ValidatorApiMethod.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Update the
SendAggregateAndProofsRequestto use the newPostAggregateAndProofsV2API post ElectraFixed Issue(s)
#8439
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog