Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix proposer config loader #8687

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix proposer config loader #8687

merged 3 commits into from
Oct 8, 2024

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Oct 8, 2024 •
edited
Loading

PR Description

Fix proposer config file loader:

  • Registrer the required deserialisers/serialisers
  • Add unit tests to make sure the required serialisers/deserialisers have been registered

Fixed Issue(s)

fixes #8686

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

tbenr
tbenr approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdi-aouadi mehdi-aouadi merged commit 29c81b8 into Consensys:master Oct 8, 2024
17 checks passed
@mehdi-aouadi mehdi-aouadi deleted the 8686-proposer-config-loader branch October 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to load proposer config
2 participants
@mehdi-aouadi @tbenr