Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Metric resource not being deployed #1316

Merged
merged 6 commits into from
Jul 16, 2021
Merged

Server Metric resource not being deployed #1316

merged 6 commits into from
Jul 16, 2021

Conversation

melowe
Copy link
Contributor

@melowe melowe commented Jul 16, 2021 •
edited
Loading

Report of /metrics endpoint not working.

  1. Missing integration tests to ensure that endpoint is deployed and accessible
  2. Once issue was found (package com.quorum.tessera.server.monitoring not being exports to hk2 library used internally by jersey.

@melowe melowe marked this pull request as ready for review July 16, 2021 09:41
ricardolyn
ricardolyn previously approved these changes Jul 16, 2021
View reviewed changes
Copy link

@ricardolyn ricardolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melowe melowe requested a review from ricardolyn July 16, 2021 13:21
@Krish1979 Krish1979 merged commit d27d02b into master Jul 16, 2021
@Krish1979 Krish1979 added bug Something isn't working 21.7.1 labels Jul 16, 2021
@Krish1979 Krish1979 changed the title Bug: Server Metric resource not being deployed Server Metric resource not being deployed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardolyn ricardolyn ricardolyn approved these changes

@chris-j-h chris-j-h Awaiting requested review from chris-j-h chris-j-h is a code owner

@namtruong namtruong Awaiting requested review from namtruong namtruong is a code owner

@nicolae-leonte-go nicolae-leonte-go Awaiting requested review from nicolae-leonte-go

@prd-fox prd-fox Awaiting requested review from prd-fox

@SatpalSandhu61 SatpalSandhu61 Awaiting requested review from SatpalSandhu61

Assignees
No one assigned
Labels
21.7.1 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melowe @ricardolyn @Krish1979