-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Hashicorp Vault to store Tessera keys #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to use vault-java-driver instead of spring-vault-core Add config item for TLS certificate path
prd-fox
previously approved these changes
Dec 6, 2018
melowe
previously approved these changes
Dec 6, 2018
namtruong
previously approved these changes
Dec 7, 2018
Update tests and usages in config package Use empty constructor w/ setters instead of multi-arg constructor
Changes have been made to support v2 of the k/v secrets engine (i.e. versioning of secrets and retrieval of previous versions of a secret) |
melowe
approved these changes
Dec 17, 2018
prd-fox
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Hashicorp Vault to supported key vaults that can be used with Tessera. Features include:
GetSecretData
andSetSecretData
added as arguments for theKeyVaultService
methods. This allows for the same method signatures to be used in the Hashicorp and Azure implementations despite each provider's different interpretation of what constitutes a secret