Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashicorp vault acceptance tests #587

Merged
merged 20 commits into from Jan 4, 2019
Merged

Hashicorp vault acceptance tests #587

merged 20 commits into from Jan 4, 2019

Conversation

chris-j-h
Copy link
Collaborator

Acceptance tests for the retrieval of keys from a Hashicorp Vault and the saving of generated keys in a Vault.

  • .travis.yml updated to ensure vault installed on Travis environment
  • Maven profile added so that Vault tests are not run by default. If profile is enabled then Vault must be installed on the machine.
  • This tests the positive scenarios; additional tests should be written to test the numerous negative scenarios.

@codecov-io
Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #587   +/-   ##
=========================================
  Coverage     99.42%   99.42%           
  Complexity     1650     1650           
=========================================
  Files           254      254           
  Lines          5040     5040           
  Branches        249      249           
=========================================
  Hits           5011     5011           
  Misses            5        5           
  Partials         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146b19a...c9da6a4. Read the comment docs.

@melowe melowe merged commit 9a1158c into Consensys:master Jan 4, 2019
@prd-fox prd-fox added the 0.8 label Jan 10, 2019
@chris-j-h chris-j-h deleted the improvement/hashicorp-acceptance-tests branch January 16, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants