Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resend publish payload fix #614

Merged
merged 1 commit into from Jan 25, 2019
Merged

Resend publish payload fix #614

merged 1 commit into from Jan 25, 2019

Conversation

chris-j-h
Copy link
Collaborator

A failed push of a payload to a recipient during a resend should not impact the push to subsequent recipients or of subsequent payloads.

@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #614 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #614      +/-   ##
============================================
+ Coverage     99.46%   99.46%   +<.01%     
  Complexity     1712     1712              
============================================
  Files           265      265              
  Lines          5226     5228       +2     
  Branches        254      254              
============================================
+ Hits           5198     5200       +2     
  Misses            5        5              
  Partials         23       23
Impacted Files Coverage Δ Complexity Δ
...va/com/quorum/tessera/api/model/ResendRequest.java 100% <ø> (ø) 7 <0> (ø) ⬇️
...om/quorum/tessera/api/model/ResendRequestType.java 100% <ø> (ø) 1 <0> (ø) ⬇️
...um/tessera/transaction/TransactionManagerImpl.java 100% <100%> (ø) 29 <2> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7921010...e8898c1. Read the comment docs.

@Krish1979 Krish1979 merged commit af2e037 into Consensys:master Jan 25, 2019
@Krish1979 Krish1979 deleted the fix/publish-payload-exception branch January 25, 2019 14:25
@prd-fox prd-fox added this to the 0.9 milestone Feb 21, 2019
@Krish1979 Krish1979 added 0.9 bug Something isn't working labels Apr 9, 2019
@Krish1979 Krish1979 removed this from the 0.9 milestone Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.9 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants