Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop throwing on network sync calls #843

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Stop throwing on network sync calls #843

merged 1 commit into from
Aug 5, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Aug 3, 2019

Make all exceptions from sending out our PartyInfo report the error to the log, but not throw the error up the call stack, so as to not stop subsequent calls.
This means that the forEach loop will not stop if an error occurred on any of the requests.

Move run messages to the general executor so they work for all polling actions. The only "useful" logging was the PartyInfo object, but this was only a reference to the object, so nothing to be gained from it.

Fixes #842

error up the callstack, so as to not stop subsequent calls.

Move run messages to the general executor so they work for all polling
actions.
@codecov-io
Copy link

codecov-io commented Aug 3, 2019

Codecov Report

Merging #843 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #843      +/-   ##
============================================
- Coverage     99.47%   99.45%   -0.02%     
+ Complexity     2068     2067       -1     
============================================
  Files           309      309              
  Lines          6073     6070       -3     
  Branches        309      309              
============================================
- Hits           6041     6037       -4     
  Misses            5        5              
- Partials         27       28       +1
Impacted Files Coverage Δ Complexity Δ
...um/tessera/threading/TesseraScheduledExecutor.java 100% <100%> (ø) 5 <2> (ø) ⬇️
.../com/quorum/tessera/partyinfo/PartyInfoPoller.java 100% <100%> (ø) 8 <2> (-1) ⬇️
.../quorum/tessera/sync/SyncResponseMessageCodec.java 96.77% <0%> (-3.23%) 5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6693bbd...f733123. Read the comment docs.

@Krish1979 Krish1979 merged commit 5ee1144 into Consensys:master Aug 5, 2019
@prd-fox prd-fox deleted the 842-partyinfo-continuation branch August 5, 2019 09:43
@prd-fox prd-fox added 0.10.0 bug Something isn't working labels Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fatal node sync call stops subsequent calls
3 participants