Stop throwing on network sync calls #843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all exceptions from sending out our
PartyInfo
report the error to the log, but not throw the error up the call stack, so as to not stop subsequent calls.This means that the
forEach
loop will not stop if an error occurred on any of the requests.Move run messages to the general executor so they work for all polling actions. The only "useful" logging was the
PartyInfo
object, but this was only a reference to the object, so nothing to be gained from it.Fixes #842