Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty party info response for older nodes to consume #847

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Add empty party info response for older nodes to consume #847

merged 3 commits into from
Aug 7, 2019

Conversation

prd-fox
Copy link
Contributor

@prd-fox prd-fox commented Aug 7, 2019

Changes made for issue #649 and #833 mean that no party info is sent back as a response to the POST /partyinfo request. This is expected on older nodes and will cause them to error in that scenario.
Although in some scenarios they will continue to function with limited capability, in the case where the "key validation" feature is not enabled, there should be full compatibility between the nodes.

This change adds an empty response to these requests, so that older nodes can continue to function properly.
When the feature is enabled, it is required that all nodes are at least version 0.10.0, and so do not need any response entity.

@codecov-io
Copy link

codecov-io commented Aug 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@552b8b8). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #847   +/-   ##
=========================================
  Coverage          ?   99.44%           
  Complexity        ?     2076           
=========================================
  Files             ?      311           
  Lines             ?     6096           
  Branches          ?      312           
=========================================
  Hits              ?     6062           
  Misses            ?        5           
  Partials          ?       29
Impacted Files Coverage Δ Complexity Δ
...java/com/quorum/tessera/p2p/PartyInfoResource.java 100% <100%> (ø) 15 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 552b8b8...648efbc. Read the comment docs.

@Krish1979 Krish1979 merged commit 7e1867c into Consensys:master Aug 7, 2019
@prd-fox prd-fox deleted the 649-backwards-compat branch August 7, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants