Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow CORS to be configured on anything but ThirdParty server #917

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

namtruong
Copy link
Collaborator

Allowing CORS config on other types of server such as P2P carry potential security issues

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #917 into master will decrease coverage by 0.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #917      +/-   ##
============================================
- Coverage     99.37%   99.35%   -0.02%     
- Complexity     2093     2094       +1     
============================================
  Files           318      318              
  Lines          5761     5772      +11     
  Branches        308      310       +2     
============================================
+ Hits           5725     5735      +10     
  Misses            5        5              
- Partials         31       32       +1
Impacted Files Coverage Δ Complexity Δ
...sera/config/constraints/ServerConfigValidator.java 95.83% <94.11%> (-4.17%) 6 <4> (+1)
.../tessera/admin/cli/subcommands/AddPeerCommand.java 97.36% <0%> (ø) 11% <0%> (ø) ⬇️
.../quorum/tessera/sync/SyncResponseMessageCodec.java 96.77% <0%> (ø) 5% <0%> (ø) ⬇️
...ain/java/com/quorum/tessera/p2p/RestP2pClient.java 93.1% <0%> (ø) 9% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76c789...bb13808. Read the comment docs.

@Krish1979 Krish1979 merged commit bef45d2 into master Nov 11, 2019
@namtruong namtruong deleted the restrict-cors-on-serverconfigs branch November 12, 2019 11:51
@Krish1979 Krish1979 added 0.10.2 0.10.2 feature User features labels Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.2 0.10.2 feature User features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants