Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api to return local public keys #936

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Conversation

namtruong
Copy link
Collaborator

Api to return a list of privateFrom and to be called via ThirdParty server.
See #924 for details

@codecov-io
Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #936 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #936      +/-   ##
===========================================
- Coverage      99.3%   99.3%   -0.01%     
+ Complexity     2077    2075       -2     
===========================================
  Files           311     311              
  Lines          5787    5779       -8     
  Branches        328     326       -2     
===========================================
- Hits           5747    5739       -8     
  Misses            5       5              
  Partials         35      35
Impacted Files Coverage Δ Complexity Δ
.../java/com/quorum/tessera/admin/ConfigResource.java 100% <ø> (ø) 8 <0> (-3) ⬇️
...ava/com/quorum/tessera/thirdparty/KeyResource.java 100% <100%> (ø) 3 <3> (?)
...m/quorum/tessera/thirdparty/ThirdPartyRestApp.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...ra/cli/keypassresolver/CliKeyPasswordResolver.java 97.82% <0%> (-0.05%) 20% <0%> (ø)
...uorum/tessera/data/migration/JdbcDataExporter.java 100% <0%> (ø) 4% <0%> (ø) ⬇️
...rum/tessera/data/migration/SqliteDataExporter.java 100% <0%> (ø) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b536ae7...dabf140. Read the comment docs.

@Consensys Consensys deleted a comment from nicolae-leonte-go Dec 2, 2019
@melowe melowe merged commit ebc1e45 into master Dec 3, 2019
@Krish1979 Krish1979 added 0.10.2 0.10.2 feature User features labels Dec 5, 2019
@namtruong namtruong deleted the api-to-return-local-public-keys branch January 6, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.10.2 0.10.2 feature User features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants