Add error message if using password list in config #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing configs containing an empty password list will still be allowed.
This is to prevent keys being decrypted before the config validation flags the use of the "passwords" field as invalid.
chris-j-h
requested review from
melowe,
namtruong,
prd-fox and
SatpalSandhu61
as code owners
Codecov Report
@@ Coverage Diff @@
## master #941 +/- ##
============================================
+ Coverage 99.3% 99.32% +0.01%
- Complexity 2075 2078 +3
============================================
Files 311 311
Lines 5781 5778 -3
Branches 326 326
============================================
- Hits 5741 5739 -2
Misses 5 5
+ Partials 35 34 -1
Continue to review full report at Codecov.
|
nicolae-leonte-go
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #935.
The
"password"field and--keys.passwordsCLI override fortesseraandtessera -keygencommands have already been disabled. This change provides feedback to users providing details of the alternative methods of providing passwords.An empty password list (i.e.
"passwords": []) is still allowed as no private password data is being provided in this case. This ensures existing configs such as those used in quorum examples are still supported.Config validation is now carried out before the
keyPasswordResolverchecks passwords and attempts to decrypt keys. This is so that invalid configs using"passwords": [...]are caught early and do not result in the decryption of key data.