Add redirect to GitHub repo and add authorization #6
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @Contextualist on Vercel. @Contextualist first needs to authorize it. |
|
I don't know if I did the environment variables correctly for Vercel, but authorization works locally |
|
|
||
| @app.route('/') | ||
| def redir(): | ||
| return redirect("https://github.com/Contextualist/glare") |
There was a problem hiding this comment.
Nice to have😉, but let's move it to vercel.json: { "src": "/", "status": 301, "headers": { "Location": "https://github.com/Contextualist/glare" } }
| @@ -47,7 +58,7 @@ def get_release(user, repo_ver, name_re): | |||
| return redirect(matched[0]) | |||
|
|
|||
| def api_req(url): | |||
| resp = httpx.get(url) | |||
| resp = httpx.get(url, headers={'Authorization': config['GITHUB_AUTHORIZATION']}) if ast.literal_eval(config['GITHUB_IS_AUTHORIZED']) == True else httpx.get(url) | |||
There was a problem hiding this comment.
I might want to simplify things a bit: if GITHUB_TOKEN is set and is non-empty, add the auth header.
| "env": { | ||
| "GITHUB_AUTHORIZATION": "Bearer YOUR-TOKEN", | ||
| "GITHUB_IS_AUTHORIZED": "False" | ||
| } |
There was a problem hiding this comment.
Maybe just use .env file as the default only way of managing the environment variables, so that it's less confusing to users.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No description provided.