Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mixed-auth-AllowAnonymous-workaround #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Mixed-auth-AllowAnonymous-workaround #34

wants to merge 1 commit into from

Conversation

g7ed6e
Copy link
Collaborator

@g7ed6e g7ed6e commented Jan 16, 2023

No description provided.

@g7ed6e g7ed6e force-pushed the feature/add-mixed-auth-allowanonymous branch 3 times, most recently from 75415b1 to 2745dd3 Compare January 16, 2023 08:58
@g7ed6e g7ed6e marked this pull request as ready for review January 16, 2023 08:59
@g7ed6e g7ed6e requested a review from mconnew January 16, 2023 08:59
@g7ed6e g7ed6e marked this pull request as draft January 16, 2023 09:19
@g7ed6e g7ed6e force-pushed the feature/add-mixed-auth-allowanonymous branch from 2745dd3 to 6465d21 Compare January 16, 2023 09:33
@g7ed6e g7ed6e marked this pull request as ready for review January 16, 2023 09:33
kevinchalet
kevinchalet reviewed Jan 18, 2023
View reviewed changes
Copy link

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you sent me the link via LinkedIn, I took the liberty to add a few remarks 😃

(I focused on the OpenIddict stuff and ignored the CoreWCF part as I'm not familiar at all with the stack)

Scenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Idp/Program.cs Outdated Show resolved Hide resolved
Scenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Idp/Program.cs Show resolved Hide resolved
Scenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Idp/Program.cs Outdated Show resolved Hide resolved
Scenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Service/Program.cs

var builder = WebApplication.CreateBuilder();

builder.Services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to add a note indicating that OpenIddict also has a validation handler that uses a more recent JWT stack, can easily switch to OAuth 2.0 introspection and is compatible with any standard OAuth 2.0 implementation (i.e not just OpenIddict.Server).

Scenarios/Authentication/Mixed-auth-allow-anonymous-workaround/Service/Program.cs Outdated Show resolved Hide resolved
@g7ed6e g7ed6e marked this pull request as draft January 18, 2023 20:04
@g7ed6e g7ed6e force-pushed the feature/add-mixed-auth-allowanonymous branch from 6465d21 to a797f03 Compare January 18, 2023 20:21
@g7ed6e g7ed6e marked this pull request as ready for review January 18, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinchalet kevinchalet kevinchalet left review comments

@mconnew mconnew Awaiting requested review from mconnew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@g7ed6e @kevinchalet