Unify command line processing #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need for a separate `config` parameter in - `format_edited_parts()` - `run_black()`
Other options are handled in parts of Black code base which are not run when we call `format_str()` directly.
Override configuration file options first with command line options, then translate the result into parameters for `FileMode()`. This simplifies parameter handling a bit.
CorreyL
reviewed
Jun 25, 2020
|
Thanks for adding the unit tests in be2ddb5, didn't have time to do it myself, but I'm glad the core logic I added was running as expected based on these unit tests. |
…mand-line-processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I touched on these ideas in my review for your pull request – couldn't help tinkering with the code myself after all. What do you think of these changes? Could we include them in your PR?