Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate abort feature #2337

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Deprecate abort feature #2337

merged 4 commits into from
Jan 13, 2025

Conversation

chipshort
Copy link
Collaborator

closes #2243

Unfortunately there is no native way to cause a compiler warning, so this is a bit of a hack.

aumetra
aumetra approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@aumetra aumetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I wish Rust had the ability to actually emit warnings instead of having to resort to these hacks..

packages/std/src/lib.rs Outdated Show resolved Hide resolved
@chipshort chipshort merged commit edc73fd into main Jan 13, 2025
9 of 38 checks passed
@chipshort chipshort deleted the co/deprecate-abort branch January 13, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aumetra aumetra aumetra approved these changes

@kulikthebird kulikthebird Awaiting requested review from kulikthebird

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate abort feature
2 participants
@chipshort @aumetra