Skip to content

Commit

Permalink
Remove PLEASE REVIEW comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ethanfrey committed Aug 3, 2021
1 parent f1e1e4f commit 0ed75c9
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 6 deletions.
4 changes: 2 additions & 2 deletions packages/cw20/schema/cw20_execute_msg.json
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@
]
},
"project": {
"description": "A URL pointing to the project behind this token. PLEASE REVIEW: is this dangerous from a security point of view?",
"description": "A URL pointing to the project behind this token.",
"type": [
"string",
"null"
Expand Down Expand Up @@ -395,7 +395,7 @@
"description": "This is used for uploading logo data, or setting it in InstantiateData",
"anyOf": [
{
"description": "A reference to an externally hosted logo. Must be a valid HTTP or HTTPS URL. PLEASE REVIEW: is this dangerous from a security point of view?",
"description": "A reference to an externally hosted logo. Must be a valid HTTP or HTTPS URL.",
"type": "object",
"required": [
"url"
Expand Down
2 changes: 1 addition & 1 deletion packages/cw20/schema/marketing_info_response.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
]
},
"project": {
"description": "A URL pointing to the project behind this token. PLEASE REVIEW: is this dangerous from a security point of view?",
"description": "A URL pointing to the project behind this token.",
"type": [
"string",
"null"
Expand Down
1 change: 0 additions & 1 deletion packages/cw20/src/logo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use serde::{Deserialize, Serialize};
#[serde(rename_all = "snake_case")]
pub enum Logo {
/// A reference to an externally hosted logo. Must be a valid HTTP or HTTPS URL.
/// PLEASE REVIEW: is this dangerous from a security point of view?
Url(String),
/// Logo content stored on the blockchain. Enforce maximum size of 5KB on all variants
Embedded(EmbeddedLogo),
Expand Down
1 change: 0 additions & 1 deletion packages/cw20/src/msg.rs
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ pub enum Cw20ExecuteMsg {
/// Setting Some("") will clear this field on the contract storage
UpdateMarketing {
/// A URL pointing to the project behind this token.
/// PLEASE REVIEW: is this dangerous from a security point of view?
project: Option<String>,
/// A longer description of the token and it's utility. Designed for tooltips or such
description: Option<String>,
Expand Down
1 change: 0 additions & 1 deletion packages/cw20/src/query.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ pub struct MinterResponse {
#[derive(Serialize, Deserialize, Clone, PartialEq, JsonSchema, Debug)]
pub struct MarketingInfoResponse {
/// A URL pointing to the project behind this token.
/// PLEASE REVIEW: is this dangerous from a security point of view?
pub project: Option<String>,
/// A longer description of the token and it's utility. Designed for tooltips or such
pub description: Option<String>,
Expand Down

0 comments on commit 0ed75c9

Please sign in to comment.