Fix cw20-base helpers.ts and point to heldernet #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanfrey
approved these changes
Dec 21, 2020
| @@ -20,24 +20,29 @@ interface Options { | |||
| readonly httpUrl: string | |||
| readonly networkId: string | |||
| readonly feeToken: string | |||
| readonly gasPrice: number | |||
| readonly gasPrice: GasPrice | |||
There was a problem hiding this comment.
This changed. Is this using 0.22 still? or 0.23?
There was a problem hiding this comment.
This is for v0.23.0
| @@ -202,7 +181,7 @@ interface CW20Contract { | |||
| // codeId must come from a previous deploy | |||
| // label is the public name of the contract in listing | |||
| // if you set admin, you can run migrations on this contract (likely client.senderAddress) | |||
| instantiate: (codeId: number, initMsg: InitMsg, label: string, admin?: string) => Promise<CW20Instance> | |||
| instantiate: (codeId: number, initMsg: Record<string, unknown>, label: string, admin?: string) => Promise<CW20Instance> | |||
There was a problem hiding this comment.
The TS compiler forces this on you?
Ideally it would auto downcast InitMsg to this more general Record<string, unknown>. And nice to have the clarity in the contract-specific API. If you have TS issues, leave it and I can look into it later.
There was a problem hiding this comment.
This is the error I get with v0.23:
../../../../../.npm/_npx/10245/lib/node_modules/@cosmjs/cli/[eval].ts:307:53 - error TS2345: Argument of type 'InitMsg' is not assignable to parameter of type 'Record<string, unknown>'.
Index signature is missing in type 'InitMsg'.
307 const result = await client.instantiate(codeId, initMsg, label, { memo: `Init ${label}`, admin});
~~~~~~~
ethanfrey
reviewed
Dec 21, 2020
orkunkl
changed the title
|
@ethanfrey I don't know which version of |
|
I'll merge this (doesn't have to be correct) and update shortly with the v0.4.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required for coralnet to heldernet update in docs.