Parametrized App, ExecProxy and MigrateProxy #150
Conversation
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 80.65% 81.79% +1.13%
==========================================
Files 36 36
Lines 1820 1774 -46
==========================================
- Hits 1468 1451 -17
+ Misses 352 323 -29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Ok, deref doesn't work; thank you for trying it out. Good job on proving me wrong.
The generic App looks far better now; it probably will be good to go. Minor comment about default.
Please get rid of the deref impl, and fall back to .app(), app_mut(), other comments are optional. If you decide one is to be done but is a bit to much work, please make an issue out of the comment for the future.
I give you approve as those are changes I believe you will solve properly.
| let version: ContractVersion = | ||
| query_contract_info(&app.app().wrap(), contract.contract_addr.to_string()).unwrap(); | ||
| let version: ContractVersion = query_contract_info( | ||
| &(*app).borrow_mut().wrap(), |
There was a problem hiding this comment.
Nah, Deref doesn't work here as we would like to - we don't want to expose RefCell. It was my bad; you were right here. .app() was better (and we need to keep it), but because queries are common let's implement the QuerierWrapper directly on our App, so we can provide the direct wrap() function on Querier (and let's rename it to querier as the wrap name without the context is confusing to me.
There was a problem hiding this comment.
tracked under #154
#140