Support gaps in query code list #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 72.47% 73.15% +0.68%
==========================================
Files 27 27
Lines 2652 2649 -3
==========================================
+ Hits 1922 1938 +16
+ Misses 617 597 -20
- Partials 113 114 +1
Continue to review full report at Codecov.
|
ethanfrey
approved these changes
Aug 6, 2020
| if res == nil { | ||
| break | ||
| } | ||
| keeper.IterateCodeInfos(ctx, func(i uint64, res types.CodeInfo) bool { |
There was a problem hiding this comment.
Ah, and the function was already there.
zemyblue
pushed a commit
to Finschia/wasmd
that referenced
this pull request
Jan 2, 2023
zemyblue
pushed a commit
to Finschia/wasmd
that referenced
this pull request
Jan 2, 2023
…ster * remotes/gaia/master: (38 commits) Merge PR CosmWasm#259: Bump SDK master commit Exec go mod tidy (CosmWasm#267) Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG Fix broken link in delegator guide (CosmWasm#262) docs: removed redundant readme.md (CosmWasm#261) Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2 Merge PR CosmWasm#250: Docs-update Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1 Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0 Merge PR CosmWasm#253: Bump SDK master commit Merge PR CosmWasm#252: v2.0.4 Changelog Merge PR CosmWasm#249: docker image build and upload for release tags Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc Merge PR CosmWasm#246: Update Archive page with explorers Merge PR CosmWasm#245: archives Bump SDK commit to the latest master (CosmWasm#239) Merge PR CosmWasm#215: Update simulation tests Update join-mainnet.md (CosmWasm#229) Incorporate SDK's latest changes (CosmWasm#227) Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the genesis import we allow gaps in the codeID range. Before the query handler would return early on a gap but now it will handle gaps and return all elements.