Fix param usage issue in genesis import #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #338 +/- ##
==========================================
- Coverage 69.86% 69.76% -0.10%
==========================================
Files 28 28
Lines 2389 2421 +32
==========================================
+ Hits 1669 1689 +20
- Misses 605 615 +10
- Partials 115 117 +2
|
ethanfrey
approved these changes
Dec 11, 2020
| t.Helper() | ||
| tempDir, err := ioutil.TempDir("", "wasm") | ||
| require.NoError(t, err) | ||
| cleanup := func() { os.RemoveAll(tempDir) } | ||
| //t.Cleanup(cleanup) todo: add with Go 1.14 | ||
| t.Cleanup(func() { os.RemoveAll(tempDir) }) |
There was a problem hiding this comment.
Such a nice trick, cleaning up a lot
| @@ -12,6 +12,8 @@ import ( | |||
| // | |||
| // CONTRACT: all types of accounts must have been already initialized/created | |||
| func InitGenesis(ctx sdk.Context, keeper *Keeper, data types.GenesisState) error { | |||
| keeper.setParams(ctx, data.Params) | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #335 (first point only)
The genesis test setup was modified in
setupKeeperto not have params set there. The reported issue was confirmed by the tests then.