Add libwasm-version query command #846
Conversation
Codecov Report
@@ Coverage Diff @@
## main #846 +/- ##
==========================================
- Coverage 60.01% 59.89% -0.12%
==========================================
Files 52 52
Lines 5972 5987 +15
==========================================
+ Hits 3584 3586 +2
- Misses 2120 2134 +14
+ Partials 268 267 -1
|
x/wasm/client/cli/query.go
Outdated
| // GetCmdVMVersion gets current libwasmvm version. | ||
| func GetCmdVMVersion() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "vm-version", |
There was a problem hiding this comment.
The term "VM" is a bit overused and wasmvm is the Go project that contains code for both sides of the FFI interface. To avoid confusion, I'd go with "libwasmvm-version". A better abbreviation would be "lib-version". If we need something short, let's use that as alias.
There was a problem hiding this comment.
sounds good to me
There was a problem hiding this comment.
renamed and added the alias as well.
| @@ -17,6 +17,7 @@ import ( | |||
| flag "github.com/spf13/pflag" | |||
|
|
|||
| "github.com/CosmWasm/wasmd/x/wasm/types" | |||
| wasmvmapi "github.com/CosmWasm/wasmvm/api" | |||
There was a problem hiding this comment.
Question to the Go pros: is the export via the /api folder good that way? Or should I make this available in the root project github.com/CosmWasm/wasmvm?
There was a problem hiding this comment.
seems like all the imports in wasmd are from the root project.
maybe just set an alias at root level var LibwasmvmVersion = api.LibwasmvmVersion
There was a problem hiding this comment.
IMHO root level would be the first place to look for this kind of functionality
There was a problem hiding this comment.
Thank you! Will move to the root. The ./api package will become internal soon (CosmWasm/wasmvm#333).
|
For some more context: this specific command is temporary and can be removed once the Cosmos SDK version command is extensible (see cosmos/cosmos-sdk#11690). |
jhernandezb
changed the title
| @@ -17,6 +17,7 @@ import ( | |||
| flag "github.com/spf13/pflag" | |||
|
|
|||
| "github.com/CosmWasm/wasmd/x/wasm/types" | |||
| wasmvmapi "github.com/CosmWasm/wasmvm/api" | |||
There was a problem hiding this comment.
IMHO root level would be the first place to look for this kind of functionality
| @@ -35,10 +36,31 @@ func GetQueryCmd() *cobra.Command { | |||
| GetCmdGetContractHistory(), | |||
| GetCmdGetContractState(), | |||
| GetCmdListPinnedCode(), | |||
| GetCmdLibVersion(), | |||
There was a problem hiding this comment.
I was expecting this at the command root level, too but I can see that it is easier to maintain this way 👍
New wasmvm introduces
LibwasmvmVersionapi method that can help to get the version of the library that is being resolved specially for dynamic linked binaries.I'm adding it as a query because it will be automatically wired to apps using wasmd but can be just a helper command and requires manual wiring.